Socket throttling allowing associated with testing Macromaker server …#379
Merged
rrivera747 merged 7 commits intodevelopfrom Mar 25, 2026
Merged
Conversation
…with large system (Mu2e at MC-2)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable UDP acknowledgement throttling knob in TransceiverSocket (to support large-system MacroMaker testing) and improves MacroMaker launch-time visibility when UDP CLI environment variables aren’t set.
Changes:
- Add an optional
interPacketGapUSecondsparameter toTransceiverSocket::acknowledge()to insert a delay between UDP chunks. - Emit a MacroMaker-mode launch warning when
OTS_MACROMAKER_UDP_IP/OTS_MACROMAKER_UDP_PORTare unset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/ots | Adds a startup warning in MacroMaker mode about missing UDP CLI env vars. |
| otsdaq/NetworkUtilities/TransceiverSocket.h | Extends acknowledge() API to accept an inter-packet gap parameter. |
| otsdaq/NetworkUtilities/TransceiverSocket.cc | Implements the inter-packet delay during chunked UDP acknowledgements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com> Agent-Logs-Url: https://github.com/art-daq/otsdaq/sessions/99058509-4306-48e1-9f75-81d6dc866efc
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eflumerf
approved these changes
Mar 25, 2026
github-project-automation
bot
moved this from 📋 Triage
to 🎉 Done
in art-daq Work Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with large system (Mu2e at MC-2)